Zum Inhalt der Seite gehen

New contributor spotlight

Issues · friendica/friendica

Friendica Communications Platform. Contribute to friendica/friendica development by creating an account on GitHub.
GitHub
#OpenSource #development #floss #helpwanted @Marek Bachmann @Grischa

teilten dies erneut

Als Antwort auf Hypolite Petovan

Marek Bachmann
Marek Bachmann
•
I think @Grischa 's Fancybox and the Image Grid Feature both complement each other seamlessly. :-)

Please let me know if there is any unwanted interfering?
@Grischa
Als Antwort auf Marek Bachmann

Montag
Montag
• •
@Marek Bachmann :friendica: your image grid feature is great. I just noticed that there are problems when the post is changed. So images are removed or added. These changes are not applied.
@Marek Bachmann
Als Antwort auf Montag

Marek Bachmann
Marek Bachmann
•
Thank you for finding that out. :-) Are you able to create an issue for this on github and provide steps to reproduce it?

Issues · friendica/friendica

Friendica Communications Platform. Contribute to friendica/friendica development by creating an account on GitHub.
GitHub
Als Antwort auf Montag

Marek Bachmann
Marek Bachmann
•
Confirmed in the way, that I am also not able to delete one image from the post. The image is not removed in the rendered post.
Als Antwort auf Marek Bachmann

Marek Bachmann
Marek Bachmann
•
I am afraid that the cause for these phenomena is a bit more deeply under the hood than I was able to dig into the code yet. I guess it is related to caching of rendered content. To fix it fast, I would need help from more expirenced @Friendica Developers :-)
@Friendica Developers
Als Antwort auf Marek Bachmann

Hypolite Petovan
Hypolite Petovan
• •
@Marek Bachmann :friendica: @Montag I don't think it's related to your work, it probably would have failed the same way before the introduction of the image grid.
@Marek Bachmann @Montag
Als Antwort auf Marek Bachmann

Hypolite Petovan
Hypolite Petovan
• •
@Marek Bachmann :friendica: @Grischa Yes, at the moment the fancybox only works on the images in the first column. It shouldn't be difficult to fix but it was a funny conflict to notice.
@Marek Bachmann @Grischa
Unbekannter Ursprungsbeitrag

Hypolite Petovan
Hypolite Petovan
• •
@Grischa @Marek Bachmann :friendica: See https://github.com/friendica/friendica/issues/12413

[fancybox] Only first column images open in gallery in new image grid feature · Issue #12413 · friendica/friendica

Cc @brockhaus It looks like the regular expression to convert image links into fancybox links needs a little refreshing. See new HTML structure:
GitHub
@Marek Bachmann @Grischa
⇧