Existing develop branch. I never touched scaling, but searched for it in the last half an hour, but did not find a place except the public function getFromBlurHash(string $blurhash, int $width, int $height) function (no idea what's their purpose, but I saw some couple of commits regarding the blur hash topic recently). This method is the only one that calls a scaling function Images::getScalingDimensions($width, $height, 90); in Images.php here:
@Roland Häder @Mihai von Glogowatz This is my fault. I deleted the test photos last night heedlessly without considering that I included them in this post -.-
Thank you so much for your valuable research. That helps a lot. Now I have a suspicion: It is related to the rotation. I opened one of the affected images in GIMP and here I see (testing portrait screenshot by the way):
…F based orient method
It's a bit confusing as there are multiple locations where images are rotated.
This PR solves the problem of portrait images being rendered distorted as landscapes by having ...
Hypolite Petovan
in reply to Friendica Entwickler Marek • • •Friendica Entwickler Marek
in reply to Hypolite Petovan • • •Hypolite Petovan
in reply to Friendica Entwickler Marek • • •Friendica Entwickler Marek
in reply to Hypolite Petovan • • •public function getFromBlurHash(string $blurhash, int $width, int $height)function (no idea what's their purpose, but I saw some couple of commits regarding the blur hash topic recently). This method is the only one that calls a scaling functionImages::getScalingDimensions($width, $height, 90);in Images.php here:https://github.com/friendica/friendica/blob/59268c600cc93591006b7f0f0e9de3a0344e7d4f/src/Object/Image.php#L785-L796
friendica/Image.php at 59268c600cc93591006b7f0f0e9de3a0344e7d4f · friendica/friendica
GitHubFriendica Entwickler Marek
in reply to Friendica Entwickler Marek • • •The phenomena is not exclusive to my dev instance here, but also occurs on my live private instance friendica.mbbit.de also on dev:
https://fdc.mbbit.de/photos/marek/album/7363616c6554657374
Might be caused by a commit after new stable 2022.12 (current stable) since the on my kassel.social instance running stable everything is (still) fine:
https://kassel.social/photos/marek/album/7363616c6554657374
Friendica Social Network | Photos
fdc.mbbit.deutzer [Friendica]
in reply to Friendica Entwickler Marek • • •Friendica Entwickler Marek
in reply to utzer [Friendica] • • •utzer [Friendica] likes this.
Friendica Entwickler Marek
in reply to Friendica Entwickler Marek • • •Hypolite Petovan likes this.
Friendica Entwickler Marek
Unknown parent • • •The problem does not occur in last stable (2022.12) but from some later commit on current develop branch.
Hank G ☑️
Unknown parent • • •Measures against several warnings and errors in the log · friendica/friendica@bdc865a
GitHubFriendica Entwickler Marek
Unknown parent • • •Thank you so much for your valuable research. That helps a lot. Now I have a suspicion: It is related to the rotation. I opened one of the affected images in GIMP and here I see (testing portrait screenshot by the way):
I will look in the changes
https://github.com/friendica/friendica/commit/8b3a9fc58a969a3d9202f6858d5228f3a28be1ef#diff-25183d8701208d633688677aff7f6ce0cd6b5d04065d37cda3664082323fed9bL353-L358
for this.
Merge pull request #12485 from annando/errors-warnings · friendica/friendica@8b3a9fc
GitHubFriendica Entwickler Marek
in reply to Friendica Entwickler Marek • • •Pull request created:
https://github.com/friendica/friendica/pull/12558
Fixed width and height not updated when image rotation is done by EXI… by MarekBenjamin · Pull Request #12558 · friendica/friendica
GitHubFriendica Entwickler Marek
in reply to Friendica Entwickler Marek • • •Hypolite Petovan likes this.